From da92e77240a430a6bda7d9dbba17392fca6af51e Mon Sep 17 00:00:00 2001
From: frederik <frederik.slos@gmail.com>
Date: Sun, 19 Oct 2025 11:21:08 +0200
Subject: [PATCH] rework recording to use one ffmpeg instance per stream, also
 use the segment to write out the individual recordings instead of restarting
 every time

---
 scripts/birdnet_recording.sh | 63 +++++++++++++++---------------------
 1 file changed, 26 insertions(+), 37 deletions(-)

diff --git a/scripts/birdnet_recording.sh b/scripts/birdnet_recording.sh
index bbf3fe4..c714a16 100755
--- a/scripts/birdnet_recording.sh
+++ b/scripts/birdnet_recording.sh
@@ -2,6 +2,15 @@
 # Performs the recording from the specified RTSP stream or soundcard
 source /etc/birdnet/birdnet.conf
 
+loop_ffmpeg(){
+  while true;do
+    if ! ffmpeg -hide_banner -xerror -loglevel $LOGGING_LEVEL -nostdin ${1} -i ${2} -vn -map a:0 -acodec pcm_s16le -ac 2 -ar 48000 -f segment -segment_format wav -segment_time ${RECORDING_LENGTH} -strftime 1 ${RECS_DIR}/StreamData/%F-birdnet-RTSP_${3}-%H:%M:%S.wav
+    then
+      sleep 1
+    fi
+  done
+}
+
 # Read the logging level from the configuration option
 LOGGING_LEVEL="${LogLevel_BirdnetRecordingService}"
 # If empty for some reason default to log level of error
@@ -15,47 +24,27 @@ fi
 [ -z $RECORDING_LENGTH ] && RECORDING_LENGTH=15
 [ -d $RECS_DIR/StreamData ] || mkdir -p $RECS_DIR/StreamData
 
-if [ ! -z $RTSP_STREAM ];then
-  # Explode the RSPT steam setting into an array so we can count the number we have
+if [ -n "${RTSP_STREAM}" ];then
+  # Explode the RTSP steam setting into an array so we can count the number we have
   RTSP_STREAMS_EXPLODED_ARRAY=(${RTSP_STREAM//,/ })
   FFMPEG_VERSION=$(ffmpeg -version | head -n 1 | cut -d ' ' -f 3 | cut -d '.' -f 1)
 
-  while true;do
-# Original loop
-#    for i in ${RTSP_STREAM//,/ };do
-#      ffmpeg -nostdin -i  ${i} -t ${RECORDING_LENGTH} -vn -acodec pcm_s16le -ac 2 -ar 48000 file:${RECS_DIR}/StreamData/$(date "+%F")-birdnet-$(date "+%H:%M:%S").wav
-#    done
-
-    # Initially start the count off at 1 - our very first stream
-    RTSP_STREAMS_STARTED_COUNT=1
-    FFMPEG_PARAMS=""
-
-    # Loop over the streams
-    for i in "${RTSP_STREAMS_EXPLODED_ARRAY[@]}"
-    do
-      if [[ "$i" =~ ^rtsps?:// ]]; then
-        [ $FFMPEG_VERSION -lt 5 ] && PARAM=-stimeout || PARAM=-timeout
-        TIMEOUT_PARAM="$PARAM 10000000"
-      elif [[ "$i" =~ ^[a-z]+:// ]]; then
-        TIMEOUT_PARAM="-rw_timeout 10000000"
-      else
-        TIMEOUT_PARAM=""
-      fi
-
-      # Map id used to map input to output (first stream being 0), this is 0 based in ffmpeg so decrement our counter (which is more human readable) by 1
-      MAP_ID=$((RTSP_STREAMS_STARTED_COUNT-1))
-      # Build up the parameters to process the RSTP stream, including mapping for the output
-      FFMPEG_PARAMS+="-vn -thread_queue_size 512 $TIMEOUT_PARAM -i ${i} -map ${MAP_ID}:a:0 -t ${RECORDING_LENGTH} -acodec pcm_s16le -ac 2 -ar 48000 file:${RECS_DIR}/StreamData/$(date "+%F")-birdnet-RTSP_${RTSP_STREAMS_STARTED_COUNT}-$(date "+%H:%M:%S").wav "
-      # Increment counter
-      ((RTSP_STREAMS_STARTED_COUNT += 1))
-    done
-
-  # Make sure were passing something valid to ffmpeg, ffmpeg will run interactive and control our loop by waiting ${RECORDING_LENGTH} between loops because it will stop once that much has been recorded
-  if [ -n "$FFMPEG_PARAMS" ];then
-    ffmpeg -hide_banner -loglevel $LOGGING_LEVEL -nostdin $FFMPEG_PARAMS
-  fi
-
+  STREAM_COUNT=1
+  # Loop over the streams
+  for i in "${RTSP_STREAMS_EXPLODED_ARRAY[@]}"
+  do
+    if [[ "$i" =~ ^rtsps?:// ]]; then
+      [ $FFMPEG_VERSION -lt 5 ] && PARAM=-stimeout || PARAM=-timeout
+      TIMEOUT_PARAM="$PARAM 10000000"
+    elif [[ "$i" =~ ^[a-z]+:// ]]; then
+      TIMEOUT_PARAM="-rw_timeout 10000000"
+    else
+      TIMEOUT_PARAM=""
+    fi
+    loop_ffmpeg "${TIMEOUT_PARAM}" "${i}" "${STREAM_COUNT}" &
+    ((STREAM_COUNT += 1))
   done
+  wait
 else
   if ! pulseaudio --check;then pulseaudio --start;fi
   if pgrep arecord &> /dev/null ;then