From 26d028f187553a7f50458254e59a06fc979a740c Mon Sep 17 00:00:00 2001
From: Alexandre <44178713+alexbelgium@users.noreply.github.com>
Date: Tue, 28 Oct 2025 14:42:37 +0100
Subject: [PATCH] Simplify file deletion process in species_tools.php
Refactor deletion logic to count deleted files instead of iterating through them.
---
scripts/species_tools.php | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/scripts/species_tools.php b/scripts/species_tools.php
index 048ab73..7df5df0 100644
--- a/scripts/species_tools.php
+++ b/scripts/species_tools.php
@@ -131,20 +131,11 @@ if (isset($_GET['delete'])) {
if ($base === false) { http_response_code(500); exit(json_encode(['error' => 'Base directory not found'])); }
$species = htmlspecialchars_decode($_GET['delete'], ENT_QUOTES);
$info = collect_species_targets($db, $species, $home, $base);
-
- $deleted = 0;
- foreach ($info['files'] as $fp) {
- if (!under_base($fp, $base)) continue;
- if (exec("sudo rm $fp 2>&1 && sudo rm $fp.png 2>&1", $output)) {
- echo "Error - file deletion failed : " . implode(", ", $output) . "
";
- exit;
- }
- $deleted++;
- }
+ $deleted = count($info['files']);
foreach ($info['dirs'] as $dir) {
if (!under_base($dir, $base)) continue;
if (exec("sudo rm -r $dir 2>&1", $output)) {
- echo "Error - directory deletion failed : " . implode(", ", $output) . "
";
+ echo "Error - files deletion failed : " . implode(", ", $output) . "
";
exit;
}
}